Skip to content

Conversation

@neighborhood999
Copy link
Collaborator

總算是把他翻完了,不過有好多地方感覺翻譯的不太 okay,
#20 有稍微記錄,這幾天會再重新 review 再做修改。

docs/FAQ.md Outdated
### 我應該什麼時候使用 Redux

Pete Hunt, one of the early contributors to React, says:
Pete Hunt,是 React 早期的 contributor,他說:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

早期的 React contributor 之一,Pete Hunt 說:

@neighborhood999
Copy link
Collaborator Author

@chentsulin 文件討論的地方都保留原文 OK 嗎?

@chentsulin
Copy link
Owner

我傾向把這些連結的標題可以翻的都翻一翻,讓我們可以快速找到重點

另外最近蠻忙的這長篇的沒其他人 review 的話我會看比較久才 merge,sorry~

docs/FAQ.md Outdated
- [Pros and Cons of Using Immutability with React](http://reactkungfu.com/2015/08/pros-and-cons-of-using-immutability-with-react-js/)

### Why is my component re-rendering too often?
### 為什麼我的 componenty 時常 re-rendering
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

componenty => typo

@lenchen1112
Copy link
Collaborator

這篇好長啊,剩下的我再慢慢看 XD 要先merge也可以~
💯

@neighborhood999
Copy link
Collaborator Author

@lenchen1112 辛苦你了!翻譯到後面有點失神XD,翻的有點不好

docs/FAQ.md Outdated
- [Stack Overflow - 在 Redux 如何處理 side-effects](http://stackoverflow.com/questions/32925837/how-to-handle-complex-side-effects-in-redux/33036594)
- [Stack Overflow - 如何在單元測試非同步 Redux action 來 mock ajax 的 回應?](http://stackoverflow.com/questions/33011729/how-to-unit-test-async-redux-actions-to-mock-ajax-response/33053465)
- [Stack Overflow - 如何在 Redux 回應 state 的改變來觸發呼叫 AJAX?](http://stackoverflow.com/questions/35262692/how-to-fire-ajax-calls-in-response-to-the-state-changes-with-redux/35675447)
- [Reddit - H說明執行非同步 API 呼叫與 Redux-Promise Middleware](https://www.reddit.com/r/reactjs/comments/469iyc/help_performing_async_api_calls_with_reduxpromise/)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多一個 H

docs/FAQ.md Outdated
- [#943 - Reducer 查詢](https://github.com/reactjs/redux/issues/943)
- [React-Boilerplate #27 - 應用程式結構](https://github.com/mxstbr/react-boilerplate/issues/27)
- [Stack Overflow - 如何建構 Redux componentscontainers](http://stackoverflow.com/questions/32634320/how-to-structure-redux-components-containers/32921576)
- [Redux 最佳作法](https://medium.com/lexical-labs-engineering/redux-best-practices-64d59775802e)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最佳實踐

@jigsawye
Copy link
Collaborator

@neighborhood999 你的 comment 是要記錄嗎XD
因為這 PR 不是你開的,怎麼不直接改

@neighborhood999
Copy link
Collaborator Author

@jigsawye 因為重新再 review 一次,想說直接打在上面XD,有原文對照看比較清楚~

docs/FAQ.md Outdated
### 我應該如何將我的 reducer 和 action creator 之間的邏輯拆開?我的「商業邏輯」應該在哪裡?

There's no single clear answer to exactly what pieces of logic should go in a reducer vs an action creator. Some developers prefer to have "fat" action creators, with "thin" reducers that simply take the data in an action and blindly merge it into the corresponding state. Others try to emphasize keeping actions as small as possible, and minimize usage of `getState` in an action creator.
邏輯放置的部份沒有一個明確的答案應該在 reducer 或是 action creator。有些開發者偏好「fataction creator、「thin」reducer,action 可以簡單的將資料 merge 到相對應的 state,其他人則嘗試保持 action,讓它盡可能的簡單,在 action creator 盡量避免使用到 `getState`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他人盡可能嘗試讓 action 保持簡單

@neighborhood999
Copy link
Collaborator Author

上次 @lenchen1112 校閱到 238 行,之後再麻煩其他人在校閱句子的正確與通順性了。

@chentsulin
Copy link
Owner

@neighborhood999 @jigsawye 麻煩協助解 conflict

@neighborhood999
Copy link
Collaborator Author

@chentsulin 收到!

@neighborhood999
Copy link
Collaborator Author

@chentsulin already resolve conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants