Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Nymlab (AVIDA Protocol) Prop31 Stage 1 implementation(#628) #682

Merged
merged 7 commits into from
Mar 13, 2024
Merged

feat!: Nymlab (AVIDA Protocol) Prop31 Stage 1 implementation(#628) #682

merged 7 commits into from
Mar 13, 2024

Conversation

Eengineer1
Copy link
Contributor

@Eengineer1 Eengineer1 commented Dec 20, 2023 •
edited
Loading

This PR introduces the finalised implementation work deriving from Proposal 31, as outlined, voted and inherited by the community here.

Stage 1 out of 3.

Includes:

@ankurdotb @whalelephant
@j0nl1 @Eengineer1
feat!: Nymlab Prop31 (#628)
da7f7c8 
* fix: LD_FLAGS -> LDFLAGS

* feat/resource: pump consensus version to v3, update ibcModule, types + keeper

* tests/resource/ibc: OnChanOpen* tests

* chore: bump x/resource pb version 2->3

* wip: comment out migration to test build

* wip test

* chore: store resource v2 types

* tests/resource: ibc on recv packets

* feat/resource: add more detailed errors

* feat: starship test base

* feat/resources: resourcePortId as const /proto revert

* chore: remove deadcode

* feat: upgrade and migration

* fix: update app migrator for keeper

* wip: conflict

* chore: bump version and remove test in go.work

* chore: make sure ibc-app-version aligns with consensus

* chore: move interchain tests out of repo

* fix: ibc connection

---------

Co-authored-by: bwty <[email protected]>
Co-authored-by: j0nl1 <[email protected]>
Co-authored-by: Tasos Derisiotis <[email protected]>
Co-authored-by: Belsy <[email protected]>
Eengineer1
Eengineer1 commented Dec 20, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@Eengineer1 Eengineer1 changed the title feat!: Nymlab Prop31 (#628) feat!: Nymlab (Vectis DAO) Prop31 Stage 1 implementation(#628) Dec 20, 2023
@Eengineer1 Eengineer1 changed the title feat!: Nymlab (Vectis DAO) Prop31 Stage 1 implementation(#628) feat!: Nymlab (AVIDA Protocol) Prop31 Stage 1 implementation(#628) Dec 21, 2023
@Eengineer1
test: Bump upgrade test suite in prep for v2 major (#683)
5a65241 
* test: Transition to v2 + relevant indicative upgrade tests

* Overall format

* Added distinction on build flags + binary paths

* Switched to ordered container

* Updated relative path references

* Switched to url-safe

* Added padding where relevant

* Cleanup

* Switch to legacy literals

* Removed optional prop info

* Added sample realistic upgrade info

* Added checksum indication

* Removed legacy querier

* Bumped extra blocks

* Streamline expected payloads as proto JSON

* Cleanup

* Added intermittent EOL

* Cleanup
Eengineer1
Eengineer1 commented Jan 8, 2024
View reviewed changes
Copy link
Contributor Author

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledging that Proposal 31 core work is complete.

We're sorting out the upgrade schedule technicalities, before rolling the release out.

@Eengineer1
fix: Add msg signature normalisation for deactivate did doc msg (#685)
e4ae42e 
* Add msg signature normalization for deactivate did doc msg

* Update MD rules

* Pin GoReleaser

* Pin GoReleaser v1.22.1

* Removed pin

---------

Co-authored-by: Tasos Derisiotis <[email protected]>
@Eengineer1 Eengineer1 mentioned this pull request Feb 26, 2024
Merged
@atheeshp @deepan95dev
@akhilkumarpilli @ankurdotb @Eengineer1
build(deps): bump cosmos-sdk to v047 (#690)
71e574b 
* bump cosmos sdk

* code clean up

* clean

* fix proto-gen

* fix build

* !build(deps): fix build (#692)

* code clean up

* clean

* fix proto-gen

* fix build

* fix build

* fix build

* fix makefile

* fix chain

* fix app.go

* protocgen

* fix ci job

* fix build

* fixes

* review changes

* review changes

* chore: delete simapp package

* feat!: `x/did` and `x/resource`  module changes according to sdk v0.47 (#691)

* chore: did module upgrade changes

* fix lint

* go mod tidy

* remove commented code

* remove commented line

* update golang version

* fix lint

* fix lint

* try fix lint

* fix lint

* fix proto-gen

* add logs

* add log

* update

* fix lint

* fix proto-gen

* add perms

* fix build

* lint fix

* lint:gofmt enabled in ci

* try fixing lint

* try fix lint

* reveert

* try lint

* try fix lint

* fix lint

* lint fixes

* fix permissions

* fix releases

* revert

* review changes

* try fixing jobs

* try fixing jobs

* add logs

* add change perms

* revert

* chore: appmodule missing methods added

* try fix build

* add perms

* chore: missing method with attrition variable

* Update .github/linters/.golangci.yaml

Co-authored-by: Akhil Kumar P <[email protected]>

* Update scripts/protocgen.sh

Co-authored-by: Akhil Kumar P <[email protected]>

* review changes

---------

Co-authored-by: atheesh <[email protected]>
Co-authored-by: atheeshp <[email protected]>
Co-authored-by: Akhil Kumar P <[email protected]>

* proto-gen

* ci: Go releaser fix (#689) (#693)

* fix: release permission check

* try fix go releaser

* touch

* touch

* release check

* try fix

* release check

* fix swagger

* fix swagger gen

* fix

* release check

* update goreleaser config

* revert changes

* fix: ante handler ibc fix

* review changes

---------

Co-authored-by: atheesh <[email protected]>
Co-authored-by: akhilkumarpilli <[email protected]>

* fix: failing tests (#694)

* fix: release permission check

* try fix go releaser

* touch

* touch

* release check

* try fix

* release check

* fix swagger

* fix swagger gen

* fix

* release check

* update goreleaser config

* revert changes

* fix: ante handler ibc fix

* fix tests

* remove test.sh

* fix: integration test check

* keys check

* try fix start script

* fix jq

* remove logs

* fix import keys

* revert

* fix: tx msgServer fixes

* fix: keys check

* fix import keys

* revert

* fix tests

* fix panic

* fix build

* add wait timer

* reduce timer

* increase time

* fix: upgrade test fixes for old binary

* fix: old binary setup.sh

* fix: localnet dir path fix

* fix: upgrade test fix

* add missing post hand;er

* fix tests

* add timer

* add post handler

* add handler

* fix test

* add timer

* try increasing the time

* decrease the timer

* fix tests

* fix lint

* fix lint

* fix lint

* fix tests

* fix

* increase time

* fix: upgrade test moduleVersion fix

* fix: upgrade test fix

* fix: test docker ps

* fix: checking docker before post test

* fix: parse fix

* fix: docker check

* fix: docker keys check

* revert: entrypoint revert

* fix: docker ps check with logs

* fix: upgrade handler with consensus, crisis

* test: docker ps logs check

* test: SendEnabled param fix

* lint: gofumpt fix

* chore: consensus module included

* chore: bank subspace fix

* lint: golang ci fix

* test: feeparam register fix

* fix: bankType param fix

* ci: Update CI workflows (#695)

* update package lock

* Update .releaserc.json

* Bump setup-go

* Update dependabot.yml

* Update pull-request.yml

* Update release workflows

* Uploaded download/upload artifact

* Ignore twitter links

* archives.rlcp is deprecated

* Standardise quotes

* ci: Resolved Integration, Upgrade test suites (#696)

* Debug

* Switch to param key table

* Skip deprecation staticcheck

* Added crisis param key table

* Added distribution parameter key table

* Added gov parameter key table

* Added mint parameter key table

* Added slashing parameter key table

* Added staking parameter key table

* Removed exclusion

* Added auth parameter key table

* Added consensus module expected definition

* Added legacy gov router registration

* Added artificial idle time against sequence mismatch

* Additional idle time

* Run sequential

* Switch to utilise other op acc

* Additional overhead

* Re-order against sequence mismatch

* Removed idle time

* Added polling for optimistic tx submission

* Additional overhead

---------

Co-authored-by: deepan95dev <[email protected]>
Co-authored-by: akhilkumarpilli <[email protected]>
Co-authored-by: Ankur Banerjee <[email protected]>
Co-authored-by: Tasos Derisiotis <[email protected]>

* chore: removed commented lines

* deps: updated bufbuild version + idle time extended in integration test

* fix: ibc defi tests (#697)

* fix ibc tests

* fix ibc tests

* add keys to gitignore

* remove unwanted line

* update ibc handler

* add comments

* fix: state sync fixes using upgrade handler (#708)

* test: state-sync upgrade handler fix

* fix: state sync param fix

---------

Co-authored-by: Deepan kumar <[email protected]>
Co-authored-by: Akhil Kumar P <[email protected]>
Co-authored-by: akhilkumarpilli <[email protected]>
Co-authored-by: deepan95dev <[email protected]>
Co-authored-by: Ankur Banerjee <[email protected]>
Co-authored-by: Tasos Derisiotis <[email protected]>
@Eengineer1 Eengineer1 merged commit be1135a into develop Mar 13, 2024
24 checks passed
@Eengineer1 Eengineer1 deleted the prop31 branch March 13, 2024 20:16
@ankurdotb ankurdotb mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eengineer1 @ankurdotb @atheeshp