Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support date only format with versionTime, resourceTime query parameters [DEV-2807] #165

Merged
merged 17 commits into from
Jun 20, 2023

Conversation

abdulla-ashurov
Copy link
Contributor

@abdulla-ashurov abdulla-ashurov commented Jun 18, 2023

  • Add implementation for supporting different formats of date in versionTime and resourceVersionTime queries:
    • Layout, e.g.: 01/02 03:04:05PM '06 -0700
    • ANSIC, e.g.: Mon Jan _2 15:04:05 2006
    • UnixDate, e.g.: Mon Jan _2 15:04:05 MST 2006
    • RubyDate, e.g.: Mon Jan 02 15:04:05 -0700 2006
    • RFC822, e.g.: 02 Jan 06 15:04 MST
    • RFC822Z, e.g.: 02 Jan 06 15:04 -0700
    • RFC850, e.g.: Monday, 02-Jan-06 15:04:05 MST
    • RFC1123, e.g.: Mon, 02 Jan 2006 15:04:05 MST
    • RFC1123Z, e.g.: Mon, 02 Jan 2006 15:04:05 -0700
    • RFC3339, e.g.: 2006-01-02T15:04:05Z07:00
    • RFC3339Nano, e.g.: 2006-01-02T15:04:05.999999999Z07:00
    • DateTime, e.g.: 2006-01-02 15:04:05
    • DateOnly, e.g.: 2006-01-02
  • Add integration tests for testing versionTime and resourceVersionTime queries with new date formats.

@ankurdotb
Copy link
Contributor

@abdulla-ashurov abdulla-ashurov self-assigned this Jun 18, 2023
@abdulla-ashurov abdulla-ashurov added documentation Improvements or additions to documentation enhancement New feature or request test Add/improve unit & integration tests labels Jun 18, 2023
@abdulla-ashurov abdulla-ashurov marked this pull request as ready for review June 18, 2023 11:17
@abdulla-ashurov abdulla-ashurov removed the documentation Improvements or additions to documentation label Jun 18, 2023
- Layout
- ANSIC
- UnixDate
- RubyDate
- RFC822
- RFC822Z
- RFC850
- RFC1123
- RFC1123Z
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging June 19, 2023 13:50 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging June 19, 2023 14:15 — with GitHub Actions Inactive
resourceVersionTime query with different date formats.
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging June 19, 2023 15:00 — with GitHub Actions Inactive
versionTime and resourceVersionTime queries with an invalid date format.
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging June 19, 2023 17:10 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging June 19, 2023 17:32 — with GitHub Actions Inactive
@lampkin-diet lampkin-diet merged commit 690e0b9 into develop Jun 20, 2023
13 checks passed
@lampkin-diet lampkin-diet deleted the DEV-2807 branch June 20, 2023 12:12
lampkin-diet pushed a commit that referenced this pull request Jun 20, 2023
… and parsing (#169)

* feat: Support date only format with versionTime, resourceTime query parameters [DEV-2807] (#165)

* Add implementation for supporting different
formats of date in versionTime and resourceVersionTime queries.

* Add positive integration tests for versionTime
query parameter.

* Remove unused date formats.

* Refactor code.

* Update positive version time integration tests.

* Update integration test.

* Add positive integration tests for testing
resourceVersionTime query.

* Update Makefile.

* Add implementation for supporting more date types:
- Layout
- ANSIC
- UnixDate
- RubyDate
- RFC822
- RFC822Z
- RFC850
- RFC1123
- RFC1123Z

* Add more positive integration test for testing
different date formats.

* Refactor code.

* Add positive integration tests for testing
resourceVersionTime query with different date formats.

* Add negative integration tests for testing
versionTime and resourceVersionTime queries with an invalid date format.

* Use constants variables instead of magic strings.

* Update golang version in Dockerfile.

* Bump golang version from v1.18 to v1.20 in go.mod.

* fix: Minor fix of "transformKey" to "transformKeys" [DEV-2813] (#164)

* Rename "transformKey" to "transformKeys".

* Update swagger OpenAPI.

* fix: Fix codeql (#170)

fix: Move codeql to using go.mod file also

---------

Co-authored-by: abdulla-ashurov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test Add/improve unit & integration tests
Development

Successfully merging this pull request may close these issues.

3 participants