fix: Fix customer creation workflow [DEV-4287] #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DaevMithran
commented
Aug 23, 2024
•
DaevMithran
commented
- Make email mandatory and unique in Cusomter entity
- Move subscription-submitter logic within webhook handler
- Dont add email in where clause if customer already has a paymentProviderId
DaevMithran
changed the title
ankurdotb
reviewed
Aug 28, 2024
DaevMithran
commented
Sep 3, 2024
DaevMithran
force-pushed
the
DEV-4287
branch
2 times, most recently
from
7bd8cf1
to
83094ed
Compare
DaevMithran
force-pushed
the
DEV-4287
branch
from
83094ed
to
3e0c63b
Compare
DaevMithran
requested review from
jay-dee7
and removed request for
Eengineer1
jay-dee7
requested changes
Sep 5, 2024
There was a problem hiding this comment.
@DaevMithran the overall work looks good. Let's resolve all the comments and then we're good
jay-dee7
reviewed
Sep 5, 2024
DaevMithran
force-pushed
the
DEV-4287
branch
from
377aae6
to
3c94595
Compare
jay-dee7
approved these changes
Sep 6, 2024
cheqd-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
## [3.3.0-develop.5](3.3.0-develop.4...3.3.0-develop.5) (2024-09-06) ### Bug Fixes * Fix customer creation workflow [DEV-4287] ([#574](#574)) ([6e1ca72](6e1ca72))
|
🎉 This issue has been resolved in version 3.3.0-develop.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
cheqd-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
## [3.3.0](3.2.0...3.3.0) (2024-09-10) ### Features * Allow additional data in credential request [DEV-4257] ([#572](#572)) ([35dc34b](35dc34b)) * Support all signature suites in jsonld [DEV-4346] ([#587](#587)) ([60581f6](60581f6)) * Update credential issue schema ([c3f9e68](c3f9e68)) ### Bug Fixes * Fix customer creation workflow [DEV-4287] ([#574](#574)) ([6e1ca72](6e1ca72)) * Fix error handling in webhook ([#590](#590)) ([5ede2ff](5ede2ff)) ### Performance Improvements * Parallelize non ledger operation tests ([#568](#568)) ([4d3ad9d](4d3ad9d))
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.