Add support for Ollama embedding models #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ollama can also serve embedding models: https://ollama.com/blog/embedding-models
zioproto
commented
Feb 20, 2025
| ret.raise_for_status() | ||
| return ret.json()["embeddings"] | ||
|
|
||
| def embed_query(self, text: str) -> List[float]: |
There was a problem hiding this comment.
@pieroit I implemented using httpx following the style of other customer embedders.
However, I am doubt if I should refactory with the import ollama module, to do more complex logic like downloading on the fly models:
examples:
There was a problem hiding this comment.
This will do for now! Thanks @zioproto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ollama can also serve embedding models:
https://ollama.com/blog/embedding-models
helps with #1026 providing the possibility to generate embeddings with Ollama
Type of change