Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wiki link to About Chewing editor box #217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Billy4195
Copy link

Because the documentation now is written on GitHub wiki, add the link
to "About Chewing editor" box for user to read the documentation

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.915% when pulling 5bd2c5a on Billy4195:issue205 into 1679266 on chewing:master.

@david50407
Copy link
Member

How about put the link in the "Help" menu rather than in about dialog?

@Billy4195
Copy link
Author

I try to add a new box named 'Documentation' in Help menu, but
it doesn't work as my prediction. Changing ui_ChewingEditor.h can
successfully add 'Documentation', but I don't know how ui_ChewingEditor.h
be created, The file 'ui_ChewingEditor.h' is generated after make

@Billy4195
Copy link
Author

@david50407 I have add documentation link in 'Help' menu.
Should I remove the link in about dialog??

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.915% when pulling 779bbb4 on Billy4195:issue205 into 1679266 on chewing:master.

@david50407
Copy link
Member

I think just leave in help menu, and remove the link from about dialog.

Because the documentation link in 'About Chewing editor is not easy
to be found, add the documentation link in Help menu make user easier
to use
@Billy4195
Copy link
Author

Billy4195 commented Apr 18, 2017

I have removed the commit that add documentation link in a dialog.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.915% when pulling 90aca9b on Billy4195:issue205 into 1679266 on chewing:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants