Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature: user should not change the pronunciation of an alphabet #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add feature: user should not change the pronunciation of an alphabet #220

wants to merge 1 commit into from

Conversation

harryoooooooooo
Copy link

I add the feature discussing in #79.

Just check if the size of phrase and bopomofo are both 1, and also they are not the same,
then the phrase shouldn't be a bopomofo.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.915% when pulling bcc6b54 on harryoooooooooo:chewing-editor-issue79 into 1679266 on chewing:master.

@david50407
Copy link
Member

What if I typed "ㄅㄉ" with bopomofo "ㄇ ㄋ"?
This case also try to create mistaken bopomofo of these words.

@harryoooooooooo
Copy link
Author

I think we should not modify the pronunciation of a single alphabet.
However, a combination of alphabet maybe occur a special meaning, so that user want to make it a phrase.
we can discuss how chewing-editor should deal with it and have a consensus.

@david50407
Copy link
Member

The truth is though we added a phrase with impossible bopomofo, chewing still not provides these phrase according to its built-in bopomofo mapping.

So even we added a phrase "ㄅㄉ" with bopomofo "ㄇ ㄋ" in the editor, we still cannot type this phrase by the bopomofo we added. And the editor should avoid to adding all these invaild phrases not just this case.

@harryoooooooooo
Copy link
Author

but actually I can type this phrase after I map "ㄅㄉ" to "ㄇ ㄋ".
screenshot from 2017-04-16 13-04-51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants