Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit test coverage #127

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Improve unit test coverage #127

merged 4 commits into from
Sep 18, 2024

Conversation

AlexKaryasov
Copy link
Contributor

@AlexKaryasov AlexKaryasov commented Aug 20, 2024

This PR will improve the overall test coverage for the rating-b repository.

The coverage situation after introducing test changes is shown in the screenshot below:

image

There are two major sources for not covered lines:

  • deprecated functionality (such as Creating PlayerRating by old API from release_id (permalink)
  • functionality related to CSV retrieval (permalink)

These two sources will be addressed as a part of the following issues:

@AlexKaryasov AlexKaryasov requested a review from razumau September 1, 2024 17:45
@AlexKaryasov AlexKaryasov marked this pull request as ready for review September 1, 2024 17:45
@razumau razumau merged commit 33c7fc2 into main Sep 18, 2024
1 check passed
@razumau razumau deleted the issue_120_test_cov branch September 18, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants