feat: #203 💪 trigger only changed

chibivue-land · Jan 1, 2024 · e523688 · e523688
1 parent 7b9da5a
commit e523688
Show file tree

Hide file tree

Showing 33 changed files with 217 additions and 41 deletions.
diff --git a/book/impls/10_minimum_example/030_reactive_system/packages/reactivity/baseHandler.ts b/book/impls/10_minimum_example/030_reactive_system/packages/reactivity/baseHandler.ts
@@ -14,8 +14,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/10_minimum_example/040_vdom_system/packages/reactivity/baseHandler.ts b/book/impls/10_minimum_example/040_vdom_system/packages/reactivity/baseHandler.ts
@@ -14,8 +14,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/10_minimum_example/050_component_system/packages/reactivity/baseHandler.ts b/book/impls/10_minimum_example/050_component_system/packages/reactivity/baseHandler.ts
@@ -14,8 +14,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/10_minimum_example/050_component_system2/packages/reactivity/baseHandler.ts b/book/impls/10_minimum_example/050_component_system2/packages/reactivity/baseHandler.ts
@@ -14,8 +14,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/10_minimum_example/050_component_system3/packages/reactivity/baseHandler.ts b/book/impls/10_minimum_example/050_component_system3/packages/reactivity/baseHandler.ts
@@ -14,8 +14,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/10_minimum_example/060_template_compiler/packages/reactivity/baseHandler.ts b/book/impls/10_minimum_example/060_template_compiler/packages/reactivity/baseHandler.ts
@@ -14,8 +14,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/10_minimum_example/060_template_compiler2/packages/reactivity/baseHandler.ts b/book/impls/10_minimum_example/060_template_compiler2/packages/reactivity/baseHandler.ts
@@ -14,8 +14,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/10_minimum_example/060_template_compiler3/packages/reactivity/baseHandler.ts b/book/impls/10_minimum_example/060_template_compiler3/packages/reactivity/baseHandler.ts
@@ -14,8 +14,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/10_minimum_example/070_sfc_compiler/packages/reactivity/baseHandler.ts b/book/impls/10_minimum_example/070_sfc_compiler/packages/reactivity/baseHandler.ts
@@ -14,8 +14,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/10_minimum_example/070_sfc_compiler2/packages/reactivity/baseHandler.ts b/book/impls/10_minimum_example/070_sfc_compiler2/packages/reactivity/baseHandler.ts
@@ -14,8 +14,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/10_minimum_example/070_sfc_compiler3/packages/reactivity/baseHandler.ts b/book/impls/10_minimum_example/070_sfc_compiler3/packages/reactivity/baseHandler.ts
@@ -14,8 +14,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/10_minimum_example/070_sfc_compiler4/packages/reactivity/baseHandler.ts b/book/impls/10_minimum_example/070_sfc_compiler4/packages/reactivity/baseHandler.ts
@@ -14,8 +14,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/20_basic_virtual_dom/010_patch_keyed_children/packages/reactivity/baseHandler.ts b/book/impls/20_basic_virtual_dom/010_patch_keyed_children/packages/reactivity/baseHandler.ts
@@ -14,8 +14,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/20_basic_virtual_dom/020_bit_flags/packages/reactivity/baseHandler.ts b/book/impls/20_basic_virtual_dom/020_bit_flags/packages/reactivity/baseHandler.ts
@@ -15,8 +15,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/20_basic_virtual_dom/040_scheduler/packages/reactivity/baseHandler.ts b/book/impls/20_basic_virtual_dom/040_scheduler/packages/reactivity/baseHandler.ts
@@ -15,8 +15,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/20_basic_virtual_dom/050_next_tick/packages/reactivity/baseHandler.ts b/book/impls/20_basic_virtual_dom/050_next_tick/packages/reactivity/baseHandler.ts
@@ -15,8 +15,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/20_basic_virtual_dom/060_other_props/packages/reactivity/baseHandler.ts b/book/impls/20_basic_virtual_dom/060_other_props/packages/reactivity/baseHandler.ts
@@ -15,8 +15,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/30_basic_reactivity_system/010_ref/packages/reactivity/baseHandler.ts b/book/impls/30_basic_reactivity_system/010_ref/packages/reactivity/baseHandler.ts
@@ -15,8 +15,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/30_basic_reactivity_system/020_shallow_ref/packages/reactivity/baseHandler.ts b/book/impls/30_basic_reactivity_system/020_shallow_ref/packages/reactivity/baseHandler.ts
@@ -15,8 +15,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/30_basic_reactivity_system/030_to_ref/packages/reactivity/baseHandler.ts b/book/impls/30_basic_reactivity_system/030_to_ref/packages/reactivity/baseHandler.ts
@@ -15,8 +15,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/30_basic_reactivity_system/040_to_refs/packages/reactivity/baseHandler.ts b/book/impls/30_basic_reactivity_system/040_to_refs/packages/reactivity/baseHandler.ts
@@ -15,8 +15,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/30_basic_reactivity_system/050_computed/packages/reactivity/baseHandler.ts b/book/impls/30_basic_reactivity_system/050_computed/packages/reactivity/baseHandler.ts
@@ -15,8 +15,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/30_basic_reactivity_system/060_computed_setter/packages/reactivity/baseHandler.ts b/book/impls/30_basic_reactivity_system/060_computed_setter/packages/reactivity/baseHandler.ts
@@ -15,8 +15,14 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+    let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };
+
+const hasChanged = (value: any, oldValue: any): boolean =>
+  !Object.is(value, oldValue);
diff --git a/book/impls/30_basic_reactivity_system/070_watch/packages/reactivity/baseHandler.ts b/book/impls/30_basic_reactivity_system/070_watch/packages/reactivity/baseHandler.ts
@@ -1,4 +1,4 @@
-import { isObject } from "../shared";
+import { hasChanged, isObject } from "../shared";
 import { track, trigger } from "./effect";
 import { reactive } from "./reactive";
 
@@ -15,8 +15,11 @@ export const mutableHandlers: ProxyHandler<object> = {
   },
 
   set(target: object, key: string | symbol, value: unknown, receiver: object) {
+        let oldValue = (target as any)[key];
     Reflect.set(target, key, value, receiver);
-    trigger(target, key);
+    if (hasChanged(value, oldValue)) {
+      trigger(target, key);
+    }
     return true;
   },
 };