return true when undo_loan is successful

[rendonluis]

What it does

undo_loan returns true when loan is successfully destroyed.

Why it is important

Fixes bug where error message is displayed even if loan was successfully undone described here

UI Change Screenshot

Old:

New:

Your bandwidth for additional changes to this PR

• I have the time and interest to make additional changes to this PR based on feedback.
• I am interested in feedback but don't need to make the changes myself.
• I don't have time or interest in making additional changes to this work.
• Other or not sure (please describe):

[jim]

Hey, awesome! Thanks for making this change. I'm thinking it would be great to add a test to cover the "undo a non-consumable loan" case, which should be very similar to the one that you updated but with a different borrow_policy. We missed adding coverage for that case whenever this code was originally written.

The CI check for "standardrb" that's failing can likely be fixed using bundle exec standardrb --fix. I think it doesn't like the use of the return keyword when you can just use true on that line to indicate what value to return.

[jim]

This looks good! Thanks for making those changes 😄