nix: add lefthook #1167
Merged
nix: add lefthook #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows pre-commit linters to run in Nix development environments. Lefthook needs to be able to invoke `node` directly so explicitly add `nodejs` to dependencies as well. This is probably worthwhile for asset generation stuff anyways.
jim
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Allows pre-commit linters to run in Nix development environments.
Why it is important
Reduces likelihood of back-and-forth based on formatting issues.
Implementation notes
Lefthook needs to be able to invoke
nodedirectly so explicitly addnodejsto dependencies as well. This is probably worthwhile for asset generation stuff anyways.