Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Solargraph with Standard Ruby #1168

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Configure Solargraph with Standard Ruby #1168

merged 1 commit into from
Oct 28, 2023

Conversation

phinze
Copy link
Contributor

@phinze phinze commented Oct 27, 2023

What it does

The current checked-in configuration runs Solargraph with a default Rubocop config which goes a bit wild with suggestions. This should make the LSP only suggest things that match the rules from Standard Ruby.

Why it is important

Having the LSP config match the linter makes it a bit faster to write complaint code since you'll get suggestions in-line when using an LSP-supporting editor.

The current checked-in configuration runs Solargraph with a default
Rubocop config which goes a bit wild with suggestions. This should make
the LSP only suggest things that match the rules from Standard Ruby.
@phinze phinze requested a review from jim October 28, 2023 00:09
Copy link
Member

@jim jim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This has needed some attention for a while now.

@phinze phinze merged commit 6671622 into main Oct 28, 2023
5 checks passed
@phinze phinze deleted the solargraph-standardrb branch October 28, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants