Initial MyTurn import and field rearrangement #1822
Conversation
| module ItemAttributes | ||
| module ItemCategorization |
There was a problem hiding this comment.
The story here is that the category code is reusable in both Item and ItemPool, but power_source is only on Item and ReservableItem, so I made this file only include the category parts.
| class AdjustItemPoolFields < ActiveRecord::Migration[7.2] | ||
| def change | ||
| remove_column :item_pools, :brand, :string | ||
| remove_column :item_pools, :model, :string | ||
| remove_column :item_pools, :size, :string | ||
| remove_column :item_pools, :strength, :string | ||
| remove_column :item_pools, :power_source, :enum, enum_type: "power_source" | ||
| remove_column :item_pools, :location_area, :string | ||
| remove_column :item_pools, :location_shelf, :string | ||
| remove_column :item_pools, :purchase_link, :string | ||
| remove_column :item_pools, :url, :string | ||
| add_column :reservable_items, :size, :string | ||
| add_column :reservable_items, :strength, :string | ||
| add_column :reservable_items, :power_source, :enum, enum_type: "power_source" | ||
| add_column :reservable_items, :location_area, :string | ||
| add_column :reservable_items, :location_shelf, :string | ||
| add_column :reservable_items, :purchase_link, :string | ||
| add_column :reservable_items, :url, :string | ||
| remove_column :reservable_items, :name, :string | ||
| add_column :item_pools, :checkout_notice, :string | ||
| end | ||
| end |
There was a problem hiding this comment.
This migration kind of tells the whole story of what's changing, in terms of which fields are moving to where.
| @@ -31,12 +31,6 @@ | |||
| <strong> | |||
| <%= link_to item_pool.name, account_item_pool_path(item_pool) %> | |||
| </strong> | |||
| <% if item_pool.size.present? %> | |||
There was a problem hiding this comment.
You can also write this as item_pool.size? if that's your preference
|
|
||
| namespace :myturn do | ||
| task reset: :environment do | ||
| # Just for development |
There was a problem hiding this comment.
Might want to through a raise unless Rails.env.development? at the top of this task.
|
|
||
| item_pool = ItemPool.create_with(creator: user).find_or_create_by!(name: row["Name"]) | ||
|
|
||
| item_pool.update( |
There was a problem hiding this comment.
Might be helpful to make this item.update!. Right now this update can fail silently. (although this one isn't caught by the rescue below)
| status: ReservableItem.statuses[:active] | ||
| ) | ||
|
|
||
| item.update( |
There was a problem hiding this comment.
This seems like a better candidate for item.update! since it's in the rescue.
What it does
ItemPooltoReservableItemas discussed at a recent meetup.ReservableItems in anItemPoolso we can see that the import works 😄This change was a bit bigger than I was hoping for, so the diff is a bit chaotic.