Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show maintenance tags #1853

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Show maintenance tags #1853

wants to merge 3 commits into from

Conversation

renwah
Copy link
Collaborator

@renwah renwah commented Feb 19, 2025

What it does

  • Addresses Maintenance ticket tag improvements #1804: Adds the ticket tags to the "items in maintenance" report as well as a filter for the tags. This currently allows you to filter on one tag at a time--if we need to filter by multiple tags at once, we'll need to update this!

Why it is important

Makes tags more helpful!

UI Change Screenshot

Screenshot 2025-02-20 at 12 27 31 PM

Implementation notes

There is a strange bug where if you refresh the page occasionally, it'll prepopulate old params into the filter fields (it will not filter the results). This is annoying, but I thought it would not come up that often. I think it has to do with the fact that I had to switch to a non-ransack form helper because it was difficult to include the tags in the ransack search (it should be compatible, but it that part of Ransack seems stale--Ransack recently required that you have to allowlist everything you search by explicitly, which I could not do easily with tags).

@renwah renwah requested a review from jim February 20, 2025 18:42
Copy link
Member

@jim jim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! It will be really nice to have this functionality.

It's too bad about the ransack form helper not cooperating. I wonder if it's possible to use the ransack form helper for most of the form and only build the tags select manually? We could even use select_form_tag, etc. and avoid the form object entirely. Feel free to say that won't work for whatever reason, I'm far from an expert with ransack myself 😄.

Otherwise, I figure that's worth a shot to have fewer form elements generated the hard/verbose way. But if it doesn't work, we can merge this and start using it.

I don't think the form redisplay issue is too terrible. Maybe it's a browser thing that can be disabled by setting autofill?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants