Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten columns, column renaming #16

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Flatten columns, column renaming #16

merged 2 commits into from
Aug 4, 2023

Conversation

clane9
Copy link
Collaborator

@clane9 clane9 commented Aug 4, 2023

The multi-index columns have been clumsy for some folks. Now return a dataframe with flat columns and a string prefix indicating the column group.

It is still possible to convert to a hierarchical index, select a particular group, or drop the group level in post-processing. This usage is shown in the example.

Other changes:

The multi-index columns have been clumsy for some folks. Now return a
dataframe with flat columns and a string prefix indicating the column
group.

It is still possible to convert to a hierarchical index, select a
particular group, or drop the group level in post-processing. This usage
is shown in the example.

Also rename sidecar -> json following the suggestion in (#15).
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 90.47% and project coverage change: +1.19% 🎉

Comparison is base (886d184) 90.70% compared to head (c97e550) 91.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   90.70%   91.89%   +1.19%     
==========================================
  Files          10       10              
  Lines         441      432       -9     
==========================================
- Hits          400      397       -3     
+ Misses         41       35       -6     
Files Changed Coverage Δ
bids2table/helpers.py 90.62% <ø> (+11.67%) ⬆️
bids2table/extractors/_inheritance.py 91.17% <75.00%> (+2.94%) ⬆️
bids2table/__init__.py 100.00% <100.00%> (ø)
bids2table/_bids2table.py 89.47% <100.00%> (-0.53%) ⬇️
bids2table/extractors/bids.py 89.65% <100.00%> (ø)
bids2table/extractors/dataset.py 89.58% <100.00%> (ø)
bids2table/extractors/metadata.py 91.17% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clane9 clane9 merged commit b4fa239 into main Aug 4, 2023
@clane9 clane9 deleted the feat/flatten branch August 4, 2023 16:58
@clane9 clane9 restored the feat/flatten branch August 7, 2023 14:15
@clane9 clane9 deleted the feat/flatten branch August 7, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant