Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-deterministic BIDS table file order in test_table #29

Merged
merged 2 commits into from
May 1, 2024

Conversation

clane9
Copy link
Collaborator

@clane9 clane9 commented Apr 12, 2024

Fix non-deterministic BIDS table file order in test_table and add more asserts to check the expected fields. Fixes #26.

Fix non-deterministic BIDS table file order and add more asserts to
check the expected fields.
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (9322fcf) to head (b7ebfb6).
Report is 2 commits behind head on main.

❗ Current head b7ebfb6 differs from pull request most recent head 5443e3a. Consider uploading reports for the commit 5443e3a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   93.18%   88.55%   -4.64%     
==========================================
  Files          10       11       +1     
  Lines         558      603      +45     
==========================================
+ Hits          520      534      +14     
- Misses         38       69      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clane9 clane9 marked this pull request as ready for review April 12, 2024 19:57
@clane9 clane9 merged commit bf7c302 into main May 1, 2024
1 check passed
@clane9 clane9 deleted the fix/table-test branch May 1, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_table_files fails because test case is incorrect
1 participant