-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user/thrift: new package (0.21.0) #3118
base: master
Are you sure you want to change the base?
Conversation
bf92bdb
to
ffd0b29
Compare
build is fixed now, missing file was not in source from apache |
main/thrift/template.py
Outdated
return self.default_devel() | ||
|
||
|
||
@subpackage("thrift-glib") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of these should have the -libs
suffix, and an appropriate self.subdesc
and perhaps thrift-libs
with self.default_libs()
as well (that does not need special subdesc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or actually, maybe no -libs
package for thrift itself, and the compiler should go in the -devel
package? i don't know this well enough, it'd be good if you elaborated on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, will add the libs suffix. If the compiler went in the -devel
package the thrift package would be empty I think. For the other compilers like for example gcc-aarch64-none-elf
the compiler is in the main package not -devel
. I don’t know about using thrift apart from other packages need it to build I guess similar to ragel
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the CI output says:
0:06:36.911 => thrift-0.21.0-r0: changed providers:
0:06:36.911 => +cmd:thrift=0.21.0-r0
0:06:36.911 => +so:libthrift.so.0.21.0=0.21.0
that means the main package contains the command thrift, and library libthrift.so.0.21.0
i guess my question is largely if libthrift.so.0.21.0 makes sense on its own
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checking on alpine libthrift is required by libparquet, which does not currently require the other thrift libs
additionally this should not be |
No description provided.