Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main/geoclue: added service file #3361

Closed
wants to merge 2 commits into from
Closed

Conversation

doskel
Copy link

@doskel doskel commented Dec 29, 2024

Description

added a dinit service to start geoclue.

Checklist

Before this pull request is reviewed, certain conditions must be met.

The following must be true for all changes:

The following must be true for template/package changes:

  • I have read Packaging.md
  • I have built and tested my changes on my machine

@doskel
Copy link
Author

doskel commented Dec 30, 2024

it's occurring to me this might be useless, as geoclue is autolaunched on each call via dbus; if anyone else wants to chime in about whether or not there's a point, i'd trust that more than my vaguely incompetent knowledge of dbus x3

@q66
Copy link
Member

q66 commented Jan 4, 2025

well since it's dbus-launched, this is indeed wrong on its own (because it means dbus can race dinit for it), but what you could do is make the dbus service launch the dinit service, see e.g. the patch in polkit and other places that already do it

though the actual right thing to do would be to have proper dbus activation support and then just refer the dbus service to the dinit service, but we don't have that yet

@q66
Copy link
Member

q66 commented Jan 15, 2025

i will close this, there is no point in adding workarounds and once there is dbus activation it should be addressed properly

@q66 q66 closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants