Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user/lshw: new package #3502

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Guiglin
Copy link
Contributor

@Guiglin Guiglin commented Jan 20, 2025

Description

lshw: HardWare LiSter for Linux: lshw is a small tool to provide detailed information on the hardware configuration of the machine. It can report exact memory configuration, firmware version, mainboard configuration, CPU version and speed, cache configuration, bus speed, etc.

Checklist

Before this pull request is reviewed, certain conditions must be met.

The following must be true for all changes:

The following must be true for template/package changes:

  • I have read Packaging.md
  • I have built and tested my changes on my machine

The following must be true for new package submissions:

  • I will take responsibility for my template and keep it up to date

user/lshw/template.py Outdated Show resolved Hide resolved
user/lshw/template.py Outdated Show resolved Hide resolved
user/lshw/template.py Outdated Show resolved Hide resolved
user/lshw/template.py Outdated Show resolved Hide resolved
user/lshw/template.py Outdated Show resolved Hide resolved
user/lshw/template.py Outdated Show resolved Hide resolved
user/lshw/template.py Outdated Show resolved Hide resolved
@Guiglin Guiglin force-pushed the gba/lshw branch 6 times, most recently from 047770a to 1e9862a Compare January 22, 2025 10:09
@Guiglin Guiglin requested a review from q66 January 23, 2025 21:20
user/lshw/template.py Outdated Show resolved Hide resolved
user/lshw/template.py Outdated Show resolved Hide resolved


def post_install(self):
self.install_file(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all these files should go to gtk-lshw and they don't currently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a patch to correctly install file when doing a make install-gui and add lines to grab those files in the subpackage

user/lshw/template.py Outdated Show resolved Hide resolved
user/lshw/template.py Outdated Show resolved Hide resolved
@Guiglin Guiglin force-pushed the gba/lshw branch 2 times, most recently from a70cc18 to c013d70 Compare January 26, 2025 22:02
@q66
Copy link
Member

q66 commented Jan 29, 2025

i noticed none of this actually respects the distro-set CFLAGS/LDFLAGS and so on, and compiles with just its own always

so that needs to be fixed

@q66
Copy link
Member

q66 commented Jan 29, 2025

also commit message has a typo

@Guiglin Guiglin force-pushed the gba/lshw branch 3 times, most recently from ae0a680 to 23b4238 Compare January 29, 2025 07:58
@Guiglin Guiglin changed the title usr/lshw: new package user/lshw: new package Jan 29, 2025
@Guiglin Guiglin requested a review from q66 January 29, 2025 09:20
@q66
Copy link
Member

q66 commented Jan 29, 2025

what's wrong with _FORTIFY_SOURCE?

@Guiglin
Copy link
Contributor Author

Guiglin commented Jan 29, 2025

It failed to build without it, I got a

/usr/include/fortify/unistd.h:156:1: error: reference to overloaded function could not be resolved; did you mean to call it?
  156 | _FORTIFY_FN(readlink) ssize_t readlink(const char *__p,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants