-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user/fcitx5-rime: new package #3516
base: master
Are you sure you want to change the base?
Conversation
i posted some initial review, once you've addressed these i will go over it again for anything i missed (it's hard to review a big PR all at once) |
addressed all comments, squashed changes into corresponding commits and rebased, force pushed This PR is ready to be reviewed. |
updated to ignore update-check for "rime-data" package |
updated fcitx5-rime to depends on the latest fcitx5 5.1.12 |
addressed all comments (checked this time), squashed all fixes and rebased. I actually didn't know if it's good to squash all comments immediately since it will make reviewing bit confusing. But since squashing and rebasing has to be done before merge, I did squashing anyway. Individual template file is not very long as well. If it's not the best practise to perform squashing during reviewing here, please let me know. I will follow in other PRs. |
Description
This PR adds four packages to user repo. It adds rime Chinese input method library and fcitx5-rime for its use in fcitx5 input method frontend.
This is my first contribution to cports, so please tell if something is not handled properly. Here are things I have done:
Among these four packages, the most controversial one is probably "rime-data". This package contains the input method schema data for rime. But there is no official release for it, as it contains multiple git repositories, and each one is user contributed and updating on a daily base.
Also, fcitx5-rime 5.1.10 was released two days ago but it requires a newer version of fcitx5 than the one cports ships. Since the fcitx5 package is in main repo, I plan to open another PR to upgrade both package (and all dependents) after this PR is merged.
Checklist
Before this pull request is reviewed, certain conditions must be met.
The following must be true for all changes:
The following must be true for template/package changes:
The following must be true for new package submissions: