-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user/opencc: enable tests #3518
Open
bjin
wants to merge
2
commits into
chimera-linux:master
Choose a base branch
from
bjin:update-opencc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q66
reviewed
Jan 29, 2025
q66
reviewed
Jan 29, 2025
q66
reviewed
Jan 29, 2025
q66
reviewed
Jan 29, 2025
q66
reviewed
Jan 29, 2025
addressed all comments, squashed and rebased |
q66
reviewed
Feb 10, 2025
q66
reviewed
Feb 10, 2025
q66
reviewed
Feb 10, 2025
q66
reviewed
Feb 10, 2025
addressed all comments, and squashed. Not rebased this time, so comparing commits should reflects all changes addressing review comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates opencc to use system library (instead of bundled ones in repository), and enable tests for "check" phase. Another package "tclap" was also added with tests enabled.
Checklist
Before this pull request is reviewed, certain conditions must be met.
The following must be true for all changes:
The following must be true for template/package changes:
The following must be true for new package submissions: