Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed all tests for:
hashPassword()
verifyPassword()
verifyAndHashPassword()
register()
Simplified
register()
tests using method spies instead of mocks. We don't care what the method returns so much as we care that theUser.create()
Sequelize method was called with the correct inputs. Function/method spies provide us with this verification. See the changed tests for a better understanding of spying / the refactor.created a
testError()
utility (intest_utils/
) for testing thrown errors. there was too much duplicated and tedious code when testing the thrown errors.