This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Indentation support for the ANTLR parser (as discussed in #192) #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kammoh
commented
Jun 20, 2016
kammoh
commented
- some clean-up of the parser code (TODO: file input could be improved, more clean-up)
- get rid of Translator and specify all syntactic rules in antlr4 grammer
- support for else-when shorthand in the grammar
- rename Begin to Block which makes more sense
|
Thank you so much for this! I've only had a chance to look over it briefly but it looks really good. I'll look into getting it merged soon. |
|
Ugh sorry for the delay, @azidar what do you think of renaming Begin to Block? I actually prefer Block but this is an API change. |
|
I think Block is clearer, I'm fine with it. |
jackkoenig
pushed a commit
that referenced
this pull request
Jun 28, 2018
Add a hack to build.sbt to allow local publishing We're merging this despite the failing tests (Jenkins ghprb isn't communicating with GitHub following security and authentication updates). We'd prefer to package all the sbt subprojects in a single jar, but current attempts to do so fail. See #208.
jackkoenig
pushed a commit
that referenced
this pull request
Jun 28, 2018
This should have been part of PR #194.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.