Support RocketChip build Chisel from source #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am generally cautious about relying on unreleased versions of dependencies..... IMO default build should always build from released versions, which developer-only flag to build from source. |
RocketChip won't depend on the unreleased version of Chisel, this is only for debug use. Default build will only build from the release version of Chisel |
sequencer
force-pushed
the
chisel_source
branch
2 times, most recently
from
5132a13 to
0e59371
Compare
sequencer
force-pushed
the
chisel_source
branch
from
0e59371 to
c05114e
Compare
sequencer
force-pushed
the
chisel_source
branch
from
c05114e to
fa8c1fa
Compare
sequencer
force-pushed
the
chisel_source
branch
from
fa8c1fa to
7b01955
Compare
|
@jerryz123 I think this is safe to get in, just provide an additional |
jerryz123
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR support RocketChip build chisel from source, this flow is not for users, only for devs to test new version of Chisel and check some backport feature is working when they are not released to maven.
Related issue:
Type of change: bug report | feature request | other enhancement
Impact: no functional change | API addition (no impact on existing code) | API modification
Development Phase: proposal | implementation
Release Notes