Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure fail on formatting also happens in pull requests #19

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Make sure fail on formatting also happens in pull requests #19

merged 1 commit into from
Feb 2, 2024

Conversation

V0XNIHILI
Copy link
Contributor

See title and related issue #18

@V0XNIHILI V0XNIHILI mentioned this pull request Feb 1, 2024
Closed
tgorochowik
tgorochowik approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@tgorochowik tgorochowik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it's still possible to achieve the same results we have now with some additional config in individual CI yamls.

Thanks

@tgorochowik tgorochowik merged commit 21a1f8c into chipsalliance:main Feb 2, 2024
1 check passed
@V0XNIHILI
Copy link
Contributor Author

Great, thanks for the quick merge!

@V0XNIHILI V0XNIHILI deleted the patch-1 branch February 2, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgorochowik tgorochowik tgorochowik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@V0XNIHILI @tgorochowik