Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Specify gradle plugins declaratively in example. #1129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

panmari
Copy link

@panmari panmari commented Feb 21, 2025

As opposed to declaratively. This is necessary to run with new java/gradle versions. See https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply. Jointly bumping version numbers for gradle and related for easier in a new flutter installation.

Tested by successfully compiling/installing example app on Android.

@chipweinberger
Copy link
Owner

you can just delete all the files and run this

cd ./example                                                                  
flutter config --enable-android 
flutter create .
flutter run

this way we are up to date with the latest recommendation

@panmari
Copy link
Author

panmari commented Feb 22, 2025

Done, the biggest difference was the additional move to kotlin.

@chipweinberger
Copy link
Owner

you have extra linux changes here

@chipweinberger
Copy link
Owner

Also, perhaps we should just delete all these files and change the docs to look like this:

Screenshot 2025-02-22 at 12 54 10 PM

@ekuleshov
Copy link
Collaborator

Also, perhaps we should just delete all these files and change the docs ...

@chipweinberger but what about Android manifest settings for bluetooth in the example app?

In particular upgrades gradle version, which makes the example app easier to run with recent java versions. Special care was taken that changes in AndroidManifest are kept.
@panmari
Copy link
Author

panmari commented Feb 23, 2025

Rebased and removed linux changes. I feel it's easier to keep the boilerplate code to allow easily running the example. Outside of big moves, like the gradle declaritive style I point out in the description, updates won't be needed.

@chipweinberger
Copy link
Owner

Also, perhaps we should just delete all these files and change the docs ...

@chipweinberger but what about Android manifest settings for bluetooth in the example app?

good point. maybe we could just leave those files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants