Fix deprecations for chrono

chmp · Jan 6, 2024 · 534d929 · 534d929
1 parent 18fdab9
commit 534d929
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/serde_arrow/src/internal/deserialization/mod.rs b/serde_arrow/src/internal/deserialization/mod.rs
@@ -1664,9 +1664,9 @@ impl Instruction for EmitDate64NaiveStr {
             i64::from_ne_bytes(buffers.u64[self.buffer][positions[self.position]].to_ne_bytes());
         positions[self.position] += 1;
 
-        // TODO: update with chrono 0.5
-        #[allow(deprecated)]
-        let val = NaiveDateTime::from_timestamp(val / 1000, (val % 1000) as u32 * 100_000);
+        let Some(val) = NaiveDateTime::from_timestamp_opt(val / 1000, (val % 1000) as u32 * 100_000) else {
+            fail!("Unsupported timestamp value: {val}");
+        };
 
         // NOTE: chrono documents that Debug, not Display, can be parsed
         Ok((self.next, Some(format!("{:?}", val).into())))
@@ -1690,9 +1690,9 @@ impl Instruction for EmitDate64UtcStr {
             i64::from_ne_bytes(buffers.u64[self.buffer][positions[self.position]].to_ne_bytes());
         positions[self.position] += 1;
 
-        // TODO: update with chrono 0.5
-        #[allow(deprecated)]
-        let val = Utc.timestamp(val / 1000, (val % 1000) as u32 * 100_000);
+        let Some(val) = Utc.timestamp_opt(val / 1000, (val % 1000) as u32 * 100_000).earliest() else {
+            fail!("Unsupported timestamp value: {val}");
+        };
 
         // NOTE: chrono documents that Debug, not Display, can be parsed
         Ok((self.next, Some(format!("{:?}", val).into())))