Skip to content

Commit

Permalink
Merge pull request #2345 from DanielRose/fix-vscode.install
Browse files Browse the repository at this point in the history
(vscode.install) fix vscode.install after 1.83
  • Loading branch information
pauby authored Nov 9, 2023
2 parents 7dc143b + b22ebcc commit fe85739
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 11 deletions.
5 changes: 3 additions & 2 deletions automatic/vscode.install/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ Build and debug modern web and cloud applications. Code is free and available on
* `/NoDesktopIcon` - Don't add a desktop icon.
* `/NoQuicklaunchIcon` - Don't add an icon to the QuickLaunch area.
* `/NoContextMenuFiles` - Don't add an _Open with Code_ entry to the context menu for files.
* `/NoContextMenuFolders` - Dont't add an _Open with Code_ entry to the context menu for folders.
* `/DontAssociateWithFiles` - Dont't associate Visual Studio Code with supported files.
* `/NoContextMenuFolders` - Don't add an _Open with Code_ entry to the context menu for folders.
* `/DontAssociateWithFiles` - Don't associate Visual Studio Code with supported files.
* `/DontAddToPath` - Don't add Visual Studio Code to the system PATH.

Example: `choco install vscode.install --params "/NoDesktopIcon /DontAddToPath"`
Expand All @@ -24,6 +24,7 @@ Example: `choco install vscode.install --params "/NoDesktopIcon /DontAddToPath"`

* The package uses default install options except that it adds context menu entries and Visual Studio Code isn't started after installation.
* For disabling the auto-update functionality see the [Visual Studio Code Auto Update Deactivation package](https://chocolatey.org/packages/visualstudiocode-disableautoupdate).
* Version 1.83.1 is the last version which is available in 32-bit and 64-bit. All later versions are 64-bit only.
* **If the package is out of date please check [Version History](#versionhistory) for the latest submitted version. If you have a question, please ask it in [Chocolatey Community Package Discussions](https://github.com/chocolatey-community/chocolatey-packages/discussions) or raise an issue on the [Chocolatey Community Packages Repository](https://github.com/chocolatey-community/chocolatey-packages/issues) if you have problems with the package. Disqus comments will generally not be responded to.**

![screenshot](https://cdn.jsdelivr.net/gh/chocolatey-community/chocolatey-coreteampackages@6dc510f16b69a2134e901f2576e991c462a18e9b/automatic/vscode/screenshot.png)
3 changes: 0 additions & 3 deletions automatic/vscode.install/tools/ChocolateyInstall.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,10 @@ Close-VSCode
$packageArgs = @{
packageName = 'vscode.install'
fileType = 'exe'
url = 'https://update.code.visualstudio.com/1.83.1/win32/stable'
url64bit = 'https://update.code.visualstudio.com/1.83.1/win32-x64/stable'

softwareName = "$softwareName"

checksum = '6b5830991395299b59d1d8f4ecb3a9d752ef64b9b39c5dd4be848851c87f3126'
checksumType = 'sha256'
checksum64 = '4ce748cdd111d88e1b7990641912a0e55904709a2cc85a72895ee6d7aa1801fd'
checksumType64 = 'sha256'

Expand Down
5 changes: 0 additions & 5 deletions automatic/vscode.install/update.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Import-Module "$PSScriptRoot\..\..\scripts\au_extensions.psm1"

if ($MyInvocation.InvocationName -ne '.') {
function global:au_BeforeUpdate {
$Latest.Checksum32 = Get-RemoteChecksum $Latest.URL32
$Latest.Checksum64 = Get-RemoteChecksum $Latest.URL64
}
}
Expand All @@ -13,9 +12,7 @@ function global:au_SearchReplace {
@{
'tools\chocolateyInstall.ps1' = @{
"(?i)(^\s*packageName\s*=\s*)('.*')" = "`$1'$($Latest.PackageName)'"
"(?i)(^\s*url\s*=\s*)('.*')" = "`$1'$($Latest.URL32)'"
"(?i)(^\s*url64bit\s*=\s*)('.*')" = "`$1'$($Latest.URL64)'"
"(?i)(^\s*checksum\s*=\s*)('.*')" = "`$1'$($Latest.Checksum32)'"
"(?i)(^\s*checksum64\s*=\s*)('.*')" = "`$1'$($Latest.Checksum64)'"
"(?i)(^[$]version\s*=\s*)('.*')" = "`$1'$($Latest.RemoteVersion)'"
}
Expand All @@ -26,13 +23,11 @@ function global:au_GetLatest {
$latestRelease = Get-GitHubRelease microsoft vscode
$version = $latestRelease.tag_name
# URLs are documented here: https://code.visualstudio.com/docs/supporting/faq#_previous-release-versions
$url32 = "https://update.code.visualstudio.com/$version/win32/stable"
$url64 = "https://update.code.visualstudio.com/$version/win32-x64/stable"

@{
Version = $version
RemoteVersion = $version
URL32 = $url32
URL64 = $url64
}
}
Expand Down
4 changes: 3 additions & 1 deletion automatic/vscode/vscode.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
* `/NoDesktopIcon` - Don't add a desktop icon.
* `/NoQuicklaunchIcon` - Don't add an icon to the QuickLaunch area.
* `/NoContextMenuFiles` - Don't add an _Open with Code_ entry to the context menu for files.
* `/NoContextMenuFolders` - Dont't add an _Open with Code_ entry to the context menu for folders.
* `/NoContextMenuFolders` - Don't add an _Open with Code_ entry to the context menu for folders.
* `/DontAssociateWithFiles` - Don't associate Visual Studio Code with supported files.
* `/DontAddToPath` - Don't add Visual Studio Code to the system PATH.
Example: `choco install vscode --params "/NoDesktopIcon /DontAddToPath"`
Expand All @@ -39,6 +40,7 @@ Example: `choco install vscode --params "/NoDesktopIcon /DontAddToPath"`
* The package uses default install options except that it adds context menu entries and Visual Studio Code isn't started after installation.
* For disabling the auto-update functionality see the [Visual Studio Code Auto Update Deactivation package](https://chocolatey.org/packages/visualstudiocode-disableautoupdate).
* Version 1.83.1 is the last version which is available in 32-bit and 64-bit. All later versions are 64-bit only.
* **If the package is out of date please check [Version History](#versionhistory) for the latest submitted version. If you have a question, please ask it in [Chocolatey Community Package Discussions](https://github.com/chocolatey-community/chocolatey-packages/discussions) or raise an issue on the [Chocolatey Community Packages Repository](https://github.com/chocolatey-community/chocolatey-packages/issues) if you have problems with the package. Disqus comments will generally not be responded to.**
![screenshot](https://cdn.jsdelivr.net/gh/chocolatey-community/chocolatey-coreteampackages@6dc510f16b69a2134e901f2576e991c462a18e9b/automatic/vscode/screenshot.png)
Expand Down

0 comments on commit fe85739

Please sign in to comment.