Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(autohotkey) Fix AutoHotkey version retrieval #2599

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

robmoss2k
Copy link
Contributor

Description

The AutoHotKey version detection relies on the AutoHotKey website, which is protected by CloudFlare. This change modifies the process to use the GitHub API instead.

Motivation and Context

AutoHotKey version detection is broken.

How Has this Been Tested?

Executed the update.ps1 script locally.

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
  • The changes only affect a single package (not including meta package).

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@@ -44,8 +44,9 @@ function global:au_BeforeUpdate {
}

function global:au_GetLatest {
$version = Invoke-WebRequest -Uri "$releases\version.txt" -UseBasicParsing | ForEach-Object Content
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this line, which uses $releases is being removed, should the definition of $releases on line 3, also be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, of course it should. Not sure why my linter didn't pick that up. Fixed.

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants