-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix os.symlink call for gather_templates --structure_paths - use abspath #74
base: master
Are you sure you want to change the base?
Conversation
Can you add a corresponding test to catch the original problem this was designed to solve? |
To get the travis tests to run, you'll have to change this line from |
Nevermind, I fixed this in #75 |
re test: there was one already (https://github.com/choderalab/ensembler/blob/master/ensembler/tests/test_initproject.py#L101) but that uses the absolute path, hence works. If I want to test using a relative path - do I have guarantee that the current folder will always be the folder in which the test script sits? Not sure how Travis works with that kind of thing. |
I would write a test that does the following:
|
Thanks! Test added. |
We're still working on fixing tests---sorry! See #80 |
No problem! |
Fixes #73
(that's adding a trailing new line at the end in the diff)