Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for the _ctSlope function #320

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

bcaddy
Copy link
Collaborator

@bcaddy bcaddy commented Aug 22, 2023

I only test the states that are actually used in the kernel.

Also, I tried refactoring all the constant parameters as template parameters to see if that helped performance. It had no impact.

@evaneschneider evaneschneider merged commit a327e6e into cholla-hydro:dev Sep 7, 2023
8 checks passed
@bcaddy bcaddy deleted the dev-ctSlopeTestAndRefactor branch September 11, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants