Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc. Small Changes for MHD timing #321

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Misc. Small Changes for MHD timing #321

merged 4 commits into from
Sep 7, 2023

Conversation

bcaddy
Copy link
Collaborator

@bcaddy bcaddy commented Aug 24, 2023 •
edited
Loading

  • Allow MHD to build with the OUTPUT and HDF5 flags absent
  • Permit single line if statements without braces in clang-tidy
  • Minor refactor of the Time::Print_Average_Times to make future changes to the header easier
  • Add a note about the reduced range of the timers to run_timing.log

@bcaddy bcaddy requested a review from alwinm August 24, 2023 18:45
@bcaddy
Add a message about how the timers work to run_timing.log
0f9c8b0 
Refactor of Time::Print_Average_Times to ease future additions to the header
@bcaddy bcaddy force-pushed the dev-improvedTiming branch from 09bf6a0 to 0f9c8b0 Compare August 24, 2023 19:03
@bcaddy bcaddy changed the title Time Hydro_Integrator only after the first time step Misc. Small Changes for MHD timing Aug 24, 2023
alwinm
alwinm approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@alwinm alwinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@evaneschneider evaneschneider merged commit 12fd8b1 into cholla-hydro:dev Sep 7, 2023
@bcaddy bcaddy deleted the dev-improvedTiming branch September 11, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alwinm alwinm alwinm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcaddy @alwinm @evaneschneider