Merge All Three PPM Kernels Into One #392
Draft
+1,458
−3,025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaddy
changed the title
Added a version of PCM that can be called as a device function from within a Riemann solver
Refactored this function to put the limiter into its own function, rename it to better reflect what it actually does, and move the characteristic to primitive conversion outside the function
Sound speed plays a similar role to the other members of EigenVecs so including it makes sense rather than passing around extra arguments
Doxygen for PCM, HLLD, and Reconstruction functions. Make all `direction` tparams of type uint instead of a mix of int, size_t, and uint. uint was chosen since direction should never be negative and size_t is misleading in that it looks like it should be an array index.
These don't change much for most builds but they do allow higher order reconstructions to be fused later if needed
This is the first step in combining the two PLM methods into one with a switch for the limiting variables. Currently that switch exists but the kernels haven't been modified to use it yet.
- Removed the PLMP kernel since PLMC can do both now - Renamed PLMC_cuda to PLM_cuda since it can now do limiting in either set of variables - Renamed plmc files to plm - The PLM kernel has MHD support for either type of limiting
Moved the computation of the eigenvectors so it's not unnecerarily done in PLMP
Refactored this function to put the limiter into its own function, rename it to better reflect what it actually does, and move the characteristic to primitive conversion outside the function
Sound speed plays a similar role to the other members of EigenVecs so including it makes sense rather than passing around extra arguments
I removed PPMC_CTU and added a call to the characteristic tracing function to PPMC_VL and renamed it to PPMC_cuda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This merges the PPMC_CTU, PPMC_VL, and PPMP kernels into one single kernel.
PPMC/PPMP Merge
Accuracy & Stability
Similar to PR #391 I ran as suite of tests to verify stability and correctness. PPM is generally more oscillatory than PLM and the implosion test is not working either before or after this refactor; in fact it's not working on dev either.
mhd_ppm_tests.zip
hydro_ppm_tests.zip
Dependencies
Depends on PRs #371, #375, #377, and #391. Until those are merged this will look like it has a lot more changes than it does. A version without all those extra changes can be found here.