-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove _specific
in the Member Names of Structs
#397
Open
bcaddy
wants to merge
4
commits into
cholla-hydro:dev
Choose a base branch
from
bcaddy:dev-removeSpecific
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaddy
force-pushed
the
dev-removeSpecific
branch
from
June 17, 2024 20:42
33005f3
to
79e1459
Compare
bcaddy
force-pushed
the
dev-removeSpecific
branch
from
June 18, 2024 14:35
57ff157
to
2b940b2
Compare
mabruzzo
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
bcaddy
force-pushed
the
dev-removeSpecific
branch
2 times, most recently
from
July 3, 2024 22:49
497df2e
to
c9f19d9
Compare
pre-commit.ci autofix |
bcaddy
force-pushed
the
dev-removeSpecific
branch
from
July 3, 2024 23:04
cf73931
to
1c3024e
Compare
bcaddy
force-pushed
the
dev-removeSpecific
branch
from
July 3, 2024 23:10
1c3024e
to
b7d6aea
Compare
pre-commit.ci autofix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
gas_energy_specific
andscalar_specific
togas_energy
andscalar
in thePrimitive
andInterfaceState
structs.