When enabling or disabling puppet check if lock file contains valid pid

[kscherer]

No description provided.

[ripienaar]

thanks:)

In order to accept this code I will need:

• A ticket at projects.puppetlabs.com for the problem
• You need to sign the CLA which you can do once logged into redmine
• Tests that verify your changes does infact fix the bug - see the spec directory for this agent

thanks

[cprice404]

Also, we might want to coordinate on how this relates to:

http://projects.puppetlabs.com/issues/3757

and related tickets--there are some API-level changes to this functionality that still haven't been re-introduced to Telly yet, but will be very shortly.

[kscherer]

@ripienaar https://projects.puppetlabs.com/issues/13440

I have already signed CLA. I will look into writing tests.

[kscherer]

@ripienaar I have added tests. Only hiccup actually running them was finding the mcollective-test project.

[ripienaar]

Sweet, will review soon thanks. Yeah we're currently working on redoing the way the plugins, tests, etc are managed and will make this more visible.

It's available as a gem called mcollective-test too

[puppetcla]

CLA Signed by kscherer on 2011-04-03 21:00:00 -0700