Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify zabbix version #3

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

epcim
Copy link

@epcim epcim commented Feb 24, 2016

This PR is based on my kitchen + centos branch. It adds support to specify exact zabbix package version to install from repository as well as the repository base URI + GPG key (ie: to be able use local repo mirror).

It should work on older rhel, ubuntu releases with proper attribute/version configuration.

@epcim epcim mentioned this pull request Feb 25, 2016
@@ -4,6 +4,9 @@
license 'GNU Public License 3.0'
description 'Installs/Configures zabbix_ng'
long_description 'Installs/Configures zabbix_ng'
version '0.1.1'
version '0.1.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change the cookbook version - I think it's usually a good idea to let the maintainer take care of this. Can you remove this from the PR?

@chr4
Copy link
Member

chr4 commented Feb 26, 2016

Thanks for the updated pull-request! The package installation recipes look good to me, besides the minor issues I commented on in the code.
One critical thing is the version lock for the packages, I don't think this is a good idea. We should just use the packages the repositories provide.

I'm still not getting the Berksfile and kitchen.yml. There are no tests to run? My suggestion is to remove the files from this pull-requests and then create another one with the tests once they are finished.

@epcim epcim mentioned this pull request Mar 1, 2016
@epcim
Copy link
Author

epcim commented Mar 1, 2016

Berksfile, the part with "group :integration" is irrelevant so I will remove it.

.kitchen.yml specifies run_list, even though there are no verification scripts ( "inspec/serverspec" ) yet it can provide you a feedback, whether the converge works on given platform (as that what "kitchen converge" will do for you)

Version lock was a bad idea, I fully agree. Will rather use what you just did in master.

I will try to update my branch according notes above in week or so. (busy now)

@chr4
Copy link
Member

chr4 commented Mar 1, 2016

Thanks, just update the #3 pull request then, feel free to force push. Looking forward for your changes!

@chr4
Copy link
Member

chr4 commented Mar 9, 2016

I just pushed some default values for Ubuntu in zabbix_server.conf, see 9511450. I guess for a port to RHEL, they need to be adapted, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants