-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify zabbix version #3
base: master
Are you sure you want to change the base?
Conversation
… from CI as more complex version spec is needed
@@ -4,6 +4,9 @@ | |||
license 'GNU Public License 3.0' | |||
description 'Installs/Configures zabbix_ng' | |||
long_description 'Installs/Configures zabbix_ng' | |||
version '0.1.1' | |||
version '0.1.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not change the cookbook version - I think it's usually a good idea to let the maintainer take care of this. Can you remove this from the PR?
Thanks for the updated pull-request! The package installation recipes look good to me, besides the minor issues I commented on in the code. I'm still not getting the |
Berksfile, the part with "group :integration" is irrelevant so I will remove it. .kitchen.yml specifies run_list, even though there are no verification scripts ( "inspec/serverspec" ) yet it can provide you a feedback, whether the converge works on given platform (as that what "kitchen converge" will do for you) Version lock was a bad idea, I fully agree. Will rather use what you just did in master. I will try to update my branch according notes above in week or so. (busy now) |
Thanks, just update the #3 pull request then, feel free to force push. Looking forward for your changes! |
I just pushed some default values for Ubuntu in |
This PR is based on my kitchen + centos branch. It adds support to specify exact zabbix package version to install from repository as well as the repository base URI + GPG key (ie: to be able use local repo mirror).
It should work on older rhel, ubuntu releases with proper attribute/version configuration.