This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
[#35] Add support list function #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @chris-l, I promised to create a pull request for list function. I see you have closed issue #35.
I'm so sorry I was busy and cannot create the pull request early.
I will be very appreciated if you take a look at this pull request.
List function is dependent on views. I see two options to do lists. The first is exporting views logic. To make views as module. It could take more time and change interface. I decided to go another way - just get result from views and handle it based on list function. It's pretty simple.
Shall I rewrite using first option?