Api module for libhttp's client #14
Conversation
| } | ||
|
|
||
| content | ||
| } |
There was a problem hiding this comment.
This whole get_content method is superfluous: std::rt::io::extensions::ReaderUtil.read_to_end() does exactly that, though as ~[u8] instead of ~str. (Given the response may not be UTF-8 encoded, this is the most sensible thing to do anyway. Correct encoding interpretation for at least HTML will come later; another—I can't remember who—is already developing at least part of it.)
There was a problem hiding this comment.
mmh, I didn't know there's a read_to_end method. Thanks for pointing it out.
P.S: Don't assume I know everything about Rust, I'm still discovering things from the stdlib 😄
|
Hey, @chris-morgan I'll cleanup this code and resubmit the PR. Can I get your thoughts around the API? I'd like to keep this work going. |
…ranch Update the servo branch with changes from upstream and to build in Servo
This PR depends on #23