This repository has been archived by the owner on Aug 23, 2018. It is now read-only.
Parse some date- and time-based headers #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not fully tested, but functional
so that we don't end up with non-headers with all-caps identifiers
Requires changing the header! macro; the docstring isn't optional.
Tests the Headers collection less and the parsing more. Test fails because timezone, nanoseconds, dst.
The test was failing because some values of the timestamp don't make it into the formatted representation: the nanoseconds and the year-day. We also currently convert all timestamps to UTC before formatting. Supply a timestamp to the tests which has zero for nsec and yday, and is already in UTC; straight equality testing then works.
|
oops, I pushed too much onto this branch |
|
Chris, how do you want to do external dependencies? |
|
Needs rust-lang/rust#16202. What do you think of it otherwise, Chris? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is in reasonable shape. Parsing of timestamps may need to be revisited in the future, but overall things are working well, and the type scheme is doing its job.