Fix installation race #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viccie30
force-pushed
the
fix-installation-race
branch
from
c649667 to
1d6633f
Compare
The old situation led to errors when building the Debian package with more than one thread.
viccie30
force-pushed
the
fix-installation-race
branch
from
1d6633f to
6cc3c03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Debian packaging builds tiny-initramfs twice with different variant names and installs both into the same directory. If the build uses multiple threads this can lead to a race condition between the copying of the init binary and the renaming.
This commit fixes the issue at the root by eliminating the separate steps and combining the installation and renaming into one invocation.