Fix number after + or - following $ not getting FP bytes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we were parsing a number at a leading '+' or '-' rather than at the digit or leading '.', then a '$' before the '+' or '-' that is part of an expression was erroneously triggering a $nnnn Spectrum Next hex constant condition and leaving out the floating point bytes. The fix was to change the number parsing to start on the digit or a leading '.', leaving the leading '+' or '-' to just copy through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we were parsing a number at a leading '+' or '-' rather than at the digit or leading '.', then a '$' before the '+' or '-' that is part of an expression (such as "CODE a$-32") was erroneously recognized as a "$nnnn" Spectrum Next hex constant and leaving out the floating point bytes. The fix was to change the number parsing to start on the digit or a leading '.', leaving the leading '+' or '-' to just copy through as it is not part of the FP number.
I did run it on the zx-next-demo.bas file and checked that the hex and binary constants were not getting FP bytes as expected.