Updates for Net::SAML2 0.17 #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal patch to improve compatibility with simplesamlphp. simpelsamlphp sends multiple signatures in the response. This patch only takes the first (outermost) signature into account. Patch taken from https://rt.cpan.org/Public/Bug/Display.html?id=76260 Author of the original patch (with additional changes): [email protected]
Changes: * added missing parameters/arguments to method doc * format argument lists via =item instead of treating them as literal code (makes a difference when shown with HTML [as on CPAN]) * surround literal values with C<...>
Make style more consistent with the other methods.
Do not rely on the fact that the file given as the 'cert' parameter also contains the private key. Add an additional attribute 'key' to the Net::SAML2::SP object that holds the filename of the private key for the certificate file given with the parameter 'cert'. This change allows using the standard certificate & private key files in lots of unix distributions (e.g. Debian, where certificate files are in /etc/ssl/certs/ and private key files are in /etc/ssl/private/)
Use Digest::SHA, wich is part of Perl 5.10, instead of Digest::SHA1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
please consider pulling the following changes into Net::SAML2's upstream repo:
This is a minimal patch against Sig.pm to make Net::SAML2 work with simplesamlphp.
It is taken from https://rt.cpan.org/Public/Bug/Display.html?id=76260, and has -
as you suggested - the namespace change left out.
I can confirm that this version works as the original patch from #76260 did.
A bunch of documentation updates:
instead of having then shown as code blocks
Make the 'return' at the end unconditional instead of having it wrapped in an 'else' block.
Allow to have certificate & key files separate by using two different parameters when
creating the SP object. The new parameter 'key' points to the filename of the private
key of the file given in 'cert'.
This helps with distributions like e.g. Debian that separate certificate & private key files.
It would be great if they made it into the next version of Net::SAML2