Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite ticks when using negative multiplier #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stephg
Copy link

@stephg stephg commented Jan 18, 2018

I was using impetus to update scrollLeft and scrollTop of a parent container and thus using a negative multiplier to invert scroll direction.

Then the stop condition for requesting new animation frames was never hit.
destroy() can't stop it either - that would be worth a fix too (#31).

@GianlucaGuarini
Copy link

This patch solves a really important issue. @chrisbateman have you any plan to merge it anytime soon? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants