Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Typescript #49

wants to merge 3 commits into from

Conversation

keonik
Copy link

@keonik keonik commented May 7, 2020

Hey everyone! I just wanted to say I love this library. Use it at work and in my personal projects. I'm gaining some familiarity with typescript and would love to get some of the typescript perks in it. I know this is coming out of nowhere so feel free to shut it down or give some feedback.

@chrisdancee
Copy link
Owner

chrisdancee commented Jun 3, 2020

Hi @keonik

Thanks a lot for the contribution - I really appreciate the TS overhaul! I have merged a couple of things, so I will get this PR up to date and add typings for the additional props.

EDIT:
Just having a look through your PR now. The level of effort you've gone to here is phenomenal. Thank you so much!

@keonik
Copy link
Author

keonik commented Jun 4, 2020

🙏 It will be a huge help for a few of my personal applications. Happy to contribute!

@transmissions11
Copy link

@chrisdancee I could really benefit from this as well!

@keonik
Copy link
Author

keonik commented Oct 16, 2020

@chrisdancee @TransmissionsDev I caught this up with what I saw on comparison with master. All I noticed was the onClose handler. Let me know if I missed something. Is there anything I can do to help with the review?

@shihfu
Copy link

shihfu commented Nov 6, 2020

Any updates on this pull request? Would love to use this on a new TS project.

@thenick775
Copy link

Bump

@thenick775
Copy link

For anyone looking for typescript support, I've published a fork here that bundles its own typings:

https://www.npmjs.com/package/react-ios-pwa-prompt-ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants