Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated common.logging #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated common.logging #96

wants to merge 1 commit into from

Conversation

Zaixu
Copy link

@Zaixu Zaixu commented Jan 13, 2016

Got one error in the tests, AllowSpecialCharacters, however got that without even changing anything, so going to assume thats something wierd with my setup.

But updated common.logging, nothing big.

@flodpanter
Copy link

Does this mean that you support Common.Logging as far as version 3.3.1 now?

@Zaixu
Copy link
Author

Zaixu commented Feb 23, 2016

Yes, at some point that it gets merged.

@Zaixu Zaixu closed this Feb 23, 2016
@Zaixu Zaixu reopened this Feb 23, 2016
@StefanCodes
Copy link

This would be great to have merged.

@chriseldredge
Copy link
Owner

Can anyone weigh in on if Common.Logging 3.x is backwards compatible with Common.Logging 2.3.1? It seems to compile the same, but I want to make sure that merging will not introduce a breaking change.

@simonlaalo
Copy link

Looking through the commits between releases I don't see any significant API / usage outside of Common.Logging.Portable.

However ILog was moved from Common.Logging to Common.Logging.Core and Common.Logging 3.0 is not a binding-redirectable/binary-compatible replacement for Common.Logging < 3.0.

NuGet stats are showing not a lot of downloads for Common.Logging < 3.0.0

I echo @StefanCodes's comment that it would be great to have this merged.

@chriseldredge
Copy link
Owner

I would be inclined to merge #87 and this into master and release a new major version since there are potential breaking changes.

I'm not actively working on this library anymore, but I'm open to bringing new maintainers on board to keep the project alive if there is interest in it.

@simonlaalo
Copy link

@chriseldredge I think I might be game. I'll try and do a full code review of the project this weekend to ensure I'm a net-positive contributor before I make a commitment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants