Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message garbled with multiple commits in push #24

Open
glensc opened this issue Feb 23, 2016 · 3 comments
Open

message garbled with multiple commits in push #24

glensc opened this issue Feb 23, 2016 · 3 comments

Comments

@glensc
Copy link

glensc commented Feb 23, 2016

my config contains ; in url:

[hooks "slack"]
        webhook-url = https://hooks.slack.com/services/
        channel = "#git"
        repos-root = /srv/git/
        changeset-url-pattern = "https://git.local/cgi-bin/gitweb.cgi?p=%repo_path%;a=commitdiff;h=%rev_hash%"
        show-full-commit = true
        show-only-last-commit = false
        username = git

this looks ok if one commit is pushed,
but shows Author Name;;;;;<https://git.local> when multiple commits are pushed.

i.e all but last commit is ok with push with multiple commits

probably related to #15 being not tested with multiple commits

@legecha
Copy link
Contributor

legecha commented Mar 29, 2016

Thanks @glensc, I've added a new PR, if you get time I'd be grateful if you'd take a look.

@glensc
Copy link
Author

glensc commented Mar 29, 2016

i'm sorry, i moved on, using gitlab-ce now!

@jjweston
Copy link
Contributor

jjweston commented Aug 8, 2016

This should be working now that pull request #27 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants