Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix malformed payload when bundeling multiple commits #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tabakhase
Copy link

reference to #24 as #27 is not fixing it (using gitweb)
resolves the greedy regex to produce ","short":false}]},&&&&&Tabakhase","value":

(using negative look-around would be cleaner, but does not seem to work there)

@init-js
Copy link

init-js commented Oct 5, 2016

that patch doesn't fix the issue either. negating [^;]* does prevent the .* from being greedy, but then any ';' in the preceding field will cause the group to be shorter than it should.

@tabakhase
Copy link
Author

Im also not super happy with [^;]* but the best possible (negative look-around didnt work).
Chances of having a ; in the commiters name is quite low tho (but for sure possible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants