Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escapes for various elements (urls, json, slack payload, directories, commit log contents) #39

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Escapes for various elements (urls, json, slack payload, directories, commit log contents) #39

wants to merge 5 commits into from

Commits on Oct 5, 2016

  1. [quoting] symmetry.

    @init-js
    init-js committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    9b3bc13 View commit details
    Browse the repository at this point in the history

  2. [emacs] 2 character indent seems to be the norm in that repo.

    @init-js
    init-js committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    a106937 View commit details
    Browse the repository at this point in the history

  3. [bugfix] Handle directory/repository names containing spaces. Quoting.

    @init-js
    init-js committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    fd73dc5 View commit details
    Browse the repository at this point in the history

  4. [bugfix] Fix parsing of gitlog. Fix json string escapes. Fix sed in h… 

    …eader.

   - if the replacement contains a '&' sed behaves differently. this fix avoids
     feeding URLs on the replacement side of sed commands. query strings may
     choke on it.

     ex.   echo "123" | sed -e 's/2/T&O/g'
           # prints  '1T2O3'

   - sed doesn't support non-greedy .*  tokenization of git-log was broken.
     the command pipeline is replaced with tokenization using bash suffix
     match. easy to follow, fast, and straightforward to maintain.

   - the @,,,,@ and ;,,,,; separators have been replaced with pseudorandom
     boundary strings. safer. 7*15bits of entropy (poorman's uuid).

   - json escapes for just \n \" and \\ was insufficient. using python
     oneliner to escape unicode.
    @init-js
    init-js committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    01078c8 View commit details
    Browse the repository at this point in the history

  5. [bugfix] Payload needs to be urlencoded. Safe to use with '&' in urls… 

    … now.

   URLs containing '&' would trigger 400 invalid_payload slack errors.
   POST body needs to be urlencoded.
    @init-js
    init-js committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    92912b3 View commit details
    Browse the repository at this point in the history