Make in place mean in place #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In place extraction should mean that if you extract a file its contents should be in the same directory as that file. This should apply even for sub directories
spreadred
reviewed
Dec 1, 2018
Remove variable name changes
on2valhalla
commented
Dec 1, 2018
|
@on2valhalla to be clear, I like your variable name suggestion. I just thought it should be a different a PR - one that refactors the entire project, not just that snippet. |
|
Yep, understood!
May need to test this, couldn't get a good build on my machine
…On Tue, Dec 11, 2018, 5:25 PM kaptainkommie ***@***.*** wrote:
@on2valhalla <https://github.com/on2valhalla> to be clear, I like your
variable name suggestion. I just thought it should be a different a PR -
one that refactors the entire project, not just that snippet.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABkSThapnXjto6gFI9n1gSVQmwvX1huCks5u4DDKgaJpZM4Y8-v3>
.
|
d8ahazard
added a commit
to d8ahazard/deluge-extractor
that referenced
this pull request
Oct 25, 2019
In place extraction should mean that if you extract a file its contents should be in the same directory as that file. This should apply even for sub directories. (Copy of chrishuan9#15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In place extraction should mean that if you extract a file its contents should be in the same directory as that file. This should apply even for sub directories