Each CalligraphyContext can have its own CalligraphyConfig

[jankovd]

Useful when Calligraphy is used in a library project where the default
configuration need not be changed, or when different defaults are needed
in multiple contexts.

[chrisjenx]

Thats pretty cool, I fear that may be too complicated for some users tho. I'll look through and see if we can make it more digestible.

[jankovd]

Note that nothing changes for any existing users of the library, this PR only increases the number of places and ways this library can be used, for example in library projects.

I'll ammend the commit to reduce the visibility of CalligraphyConfig.from since it is of no use to anyone outside the package, and with that, the only api change would be the new CalligraphyContextWrapper.wrap(Context, CalligraphyConfig) method.

[chrisjenx]

OK I'll re-review once that's done

On Thu, 15 Oct 2015 12:33 Dejan Jankov [email protected] wrote:

Note that nothing changes for any existing users of the library, this
commit only increases the number of places and ways this library can be
used, for exaple in library projects.

I'll ammend the commit to reduce the visibility of CalligraphyConfig.from
since it is of no use to anyone outside the package, and with that, the
only api change would be the new CalligraphyContextWrapper.wrap(Context,
CalligraphyConfig) method.

—
Reply to this email directly or view it on GitHub
#220 (comment)
.

[jankovd]

Done.

[jankovd]

Do you have any plans for reviewing and possibly merging this PR?

[chrisjenx]

@jankovd this would be better suited to https://github.com/InflationX/ViewPump